-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: added persistent config item to redis handler Session
#9793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added persistent config item to redis handler Session
#9793
Conversation
59fe543 to
fdaa124
Compare
|
@ddevsr wait for the first PR to be accepted. There is no need to send an additional one in advance. What if your first PR changes? |
fdaa124 to
02c8284
Compare
michalsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include this in the user guide? The following spot seems appropriate: https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/libraries/sessions.rst?plain=1#L719-L721
Something like:
Starting with v4.7.0, you can define a persistent connection::
public string $savePath = 'tcp://localhost:6379?persistent=1';
|
Hey @ddevsr , are you still interested in this feature? If yes, could you update this PR in the next two weeks? |
fix: test persistent parameter false
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
e0110c3 to
3ec9e2f
Compare
3ec9e2f to
e309b55
Compare
Description
Needed #9792Checklist: